MNT Lint all scss but don't over-reach #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
force-pushed
the
pulls/3.2/lint-scss
branch
from
9a043b2 to
93cbed5
Compare
GuySartorelli
commented
Jun 10, 2024
| "lint-sass": "stylelint **/client/src/**/*.scss", | ||
| "lint-sass": "stylelint client/src", |
There was a problem hiding this comment.
I know this looks like it was correct, but it wasn't.
GuySartorelli
commented
Jun 10, 2024
| "lint": "eslint client/src && yarn lint-sass", | ||
| "lint": "yarn lint-js && yarn lint-sass", |
There was a problem hiding this comment.
This is unrelated but makes sense to do while I'm in here.
GuySartorelli
force-pushed
the
pulls/3.2/lint-scss
branch
from
93cbed5 to
4ab09e9
Compare
emteknetnz
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all client/src was being linted before - see changes to eslint-config in the related PR.
Issue